[Woo POS][Settings i2] Update designs for detail navigation #16313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
joshheald
approved these changes
Nov 4, 2025
Contributor
joshheald
left a comment
joshheald
left a comment
There was a problem hiding this comment.
Looks good, works well.
One small thing – it'd be nice to rename it from POSSettingsCardView to POSSettingsCard while we're in here, if you get the chance.
Another unrelated note inline about navigation stacks
| } | ||
| } | ||
| } | ||
| .navigationViewStyle(.stack) |
Contributor
There was a problem hiding this comment.
Preexisting, but just spotted this – support form should use a NavigationStack as NavigationView is deprecated.
Contributor
Author
There was a problem hiding this comment.
Good catch, updated on 857b948
I don't get warnings of this one, but seems we use it 75 more times across the app 😨 , will log it into the iOS17+ updates project
Base automatically changed from
task/WOOMOB-1571-pos-settings-sidebar-nav
to
trunk
November 5, 2025 02:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes WOOMOB-1572
Description
Continuation of #16312 , this PR updates the detail navigation (right side) of POS Settings to latest i2 designs qKAWGmvUsvfnW0Z4CssJHe-fi so we use the updated cards while navigating through different settings. Updates are not behind feature flag.
Outside of scope of this PR:
These will be handled in WOOMOB-1637
Changes
POSSettingsCardViewTest Steps
Screenshots
Screen.Recording.2025-11-04.at.16.33.06.mov